Skip to content

#381 End current edit when IsReadOnly is set to false#389

Merged
w-ahmad merged 5 commits into
w-ahmad:mainfrom
Mangepange:bugfix_381_isreadonly_editing
Jul 4, 2026
Merged

#381 End current edit when IsReadOnly is set to false#389
w-ahmad merged 5 commits into
w-ahmad:mainfrom
Mangepange:bugfix_381_isreadonly_editing

Conversation

@Mangepange

Copy link
Copy Markdown

Added code for solving issue #381

When IsReadOnly is changed and there´s an ongoing edit operation it is cancelled.
This is solved for both IsReadOnly changes on TableView and TableViewColumn.

@w-ahmad w-ahmad left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mangepange, can you limit it to only when IsReadOnly changes to true (in both TableView and TableViewColumn handlers)

@Mangepange Mangepange requested a review from w-ahmad July 3, 2026 07:09

@w-ahmad w-ahmad left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@w-ahmad w-ahmad merged commit 21afb4f into w-ahmad:main Jul 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants